Create Dockerfile

[guitcastro]

What is the purpose of the pull request

Create a docker file to run the project

Brief change log

• Create Dockerfike

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

[the-other-tim-brown]

Should we add some readme about how to use this dockerfile?

[the-other-tim-brown]

can you add a comment explain why we want these flags?

[guitcastro]

It's necessary to added this flag to run spark on java >= 17.

Sorry, I forgot to send the link

[the-other-tim-brown]

Does this mean that only the jar will be included in the final image and not all the classes? I have not used a multi-stage build before.

[guitcastro]

Yep, exactly!

[guitcastro]

Should we add some readme about how to use this dockerfile?

Yes, that's how I am using, but you probably should deploy the image somewhere. I could create a PR with a workflow to publish on github container register, if you agree.

docker run \
  -v ./xtable/config.yml:/xtable/config.yml \
  -v ./xtable/core-site.xml:/xtable/core-site.xml \
  -v ./xtable/catalog.yml:/xtable/catalog.yml \
  registry.gitlab.com/pedalin/xtable-docker-image:4420d2b6 \
  --datasetConfig /xtable/config.yml --hadoopConfig /xtable/core-site.xml --icebergCatalogConfig xtable/catalog.yml

[the-other-tim-brown]

Should we add some readme about how to use this dockerfile?

Yes, that's how I am using, but you probably should deploy the image somewhere. I could create a PR with a workflow to publish on github container register, if you agree.

docker run \
  -v ./xtable/config.yml:/xtable/config.yml \
  -v ./xtable/core-site.xml:/xtable/core-site.xml \
  -v ./xtable/catalog.yml:/xtable/catalog.yml \
  registry.gitlab.com/pedalin/xtable-docker-image:4420d2b6 \
  --datasetConfig /xtable/config.yml --hadoopConfig /xtable/core-site.xml --icebergCatalogConfig xtable/catalog.yml

@guitcastro can you update the README with this as an option for building and running? I am imagining users that are not setup with java locally could benefit from this.

I will check where we can publish the images, we are currently doing our first release as part of the incubator program

[guitcastro]

@the-other-tim-brown Right, I will update the Readme!

[the-other-tim-brown]

@guitcastro can you squash this down to a single commit for me after adding the license? Our current setup doesn't allow us to do squash and merge from GitHub so just need things to be a single, cleaned up commit before I merge it

[the-other-tim-brown]

You'll need to add the apache license in the comments here to make CI pass

[guitcastro]

Continue on #506