Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a UUID type #112

Closed
the-other-tim-brown opened this issue Oct 25, 2023 · 11 comments
Closed

Add a UUID type #112

the-other-tim-brown opened this issue Oct 25, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@the-other-tim-brown
Copy link
Contributor

Create a UUID type in OneType and handle it appropriately in all converters. Only Iceberg has a concept of a UUID and it is a fixed size byte array in the underlying parquet files. We should aim to preserve the metadata that this byte array came from a UUID for round trip conversions.

@the-other-tim-brown the-other-tim-brown added enhancement New feature or request good first issue Good for newcomers labels Oct 25, 2023
@yyy1000
Copy link

yyy1000 commented Dec 4, 2023

I'm new to this project and want to begin contribute with this:)

@the-other-tim-brown
Copy link
Contributor Author

@yyy1000 welcome! Feel free to assign it to yourself when you begin working on it.

@yyy1000
Copy link

yyy1000 commented Dec 5, 2023

/assign
How can I assign it to myself? :)

@the-other-tim-brown
Copy link
Contributor Author

/assign How can I assign it to myself? :)

I've assigned it to you. It may be a github permissions issue and only repo owners can assign. In the top right there is assignees if you are not familiar with the GitHub UI for issues.
image

@genzarchitect
Copy link

is this issue resolved ?
Could you assign it to me ?

@the-other-tim-brown
Copy link
Contributor Author

@genzarchitect this is not resolved but there is an open PR. @yyy1000 are you still working on this?

@yyy1000
Copy link

yyy1000 commented Jan 17, 2024

@the-other-tim-brown Sorry about that, I became busy these days so I can't work on this. :(

@the-other-tim-brown
Copy link
Contributor Author

@yyy1000 no worries. Feel free to reach out when you are less busy if you want to work on any other features.

@genzarchitect I've reassigned this to you. Take a look at #267 for the progress that was already made on the task.

@danielhumanmod
Copy link
Contributor

@the-other-tim-brown I noticed this issue has been open for more than 6 months, and I was wondering if I could help by working on it if @genzarchitect is busy currently?

@the-other-tim-brown
Copy link
Contributor Author

@danielhumanmod, yes feel free to assign it to yourself and let me know if you need any help getting setup or making the changes.

@danielhumanmod
Copy link
Contributor

Thanks, @the-other-tim-brown . I’ve submitted an initial PR (#518) to address this issue. However, I’ve also left some comments in the PR as questions regarding the Hudi converter. I would greatly appreciate it if you could take a look and help me with those.

BTW, would you mind helping to assign this issue to me? It seems I don’t have the permissions. XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants