[LIVY-977][SERVER][CONF] Livy can not be started if HDFS is still in safe mode #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…safe mode Added safe mode check to implement safe mode
askhatri
approved these changes
Jan 24, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
=============================================
- Coverage 65.45% 28.79% -36.66%
+ Complexity 954 385 -569
=============================================
Files 103 103
Lines 6084 6102 +18
Branches 922 925 +3
=============================================
- Hits 3982 1757 -2225
- Misses 1546 3985 +2439
+ Partials 556 360 -196 ☔ View full report in Codecov by Sentry. |
|
LGTM, thank you for your contribution @RajshekharMuchandi ! |
jimenefe
pushed a commit
to onedot-data/incubator-livy
that referenced
this pull request
Oct 15, 2024
…safe mode (apache#440) ## What changes were proposed in this pull request? HDFS safe mode is checked when livy session is created. If safe mode is ON, then IllegalStateException is thrown after max retry attempts (configurable) with safe mode interval (configurable) checks are done. If safe mode is OFF, then livy will be able to create session. https://issues.apache.org/jira/browse/LIVY-977 ## How was this patch tested? Added unit test cases to validate code changes. Also, done manual testing in CDP cluster by creating livy sessions with HDFS safe mode check ON/OFF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added safe mode check to implement safe mode
What changes were proposed in this pull request?
HDFS safe mode is checked when livy session is created. If safe mode is ON, then IllegalStateException is thrown after max retry attempts (configurable) with safe mode interval (configurable) checks are done. If safe mode is OFF, then livy will be able to create session.
https://issues.apache.org/jira/browse/LIVY-977
How was this patch tested?
Added unit test cases to validate code changes. Also, done manual testing in CDP cluster by creating livy sessions with HDFS safe mode check ON/OFF.