Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if function type is nil before attempting to register the function #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pocockn
Copy link

@pocockn pocockn commented Mar 1, 2023

If you don't pass a function type to the builders WithSpec method it doesn't error within the Go SDK but the function isn't registered within Flink and doesn't run correctly.

You can see the error within the Flink UI but the Go SDK just logs

"registering Stateful Function nil"

And then carries on as usual

I've added a check to ensure that a function type is passed down into the builders WithSpec method

Copy link

@tbal999 tbal999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a useful exception

Copy link

@phatjam98 phatjam98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I am also just getting started as a contributor to Statefun. Is there a JIRA ticket for this one?

@pocockn
Copy link
Author

pocockn commented Mar 7, 2023

This looks great. I am also just getting started as a contributor to Statefun. Is there a JIRA ticket for this one?

No JIRA ticket, would be happy to make one. Do you have a link to the board?

@pocockn
Copy link
Author

pocockn commented Mar 9, 2023

This looks great. I am also just getting started as a contributor to Statefun. Is there a JIRA ticket for this one?

https://issues.apache.org/jira/browse/FLINK-31384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants