Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export PartitionEvaluatorArgs from datafusion_expr::function #12878

Merged

Conversation

Michael-J-Ward
Copy link
Contributor

This is needed to implement the WindowUDF trait.

Which issue does this PR close?

Closes #12877.

Rationale for this change

PartitionEvaluatorArgs is needed to implement WindowUDF, but is not currently re-exported.

What changes are included in this PR?

PartitionEvaluatorArgs is re-exported in datafusion_expr::function.

I placed it here because that is whereWindowUDFFieldArgs is re-exported.

Are these changes tested?

N/A

Are there any user-facing changes?

Not from any released version.

This is needed to implement the WindowUDF trait.
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Oct 11, 2024
@jcsherin
Copy link
Contributor

Thanks @Michael-J-Ward

Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
Copy link
Contributor

alamb commented Oct 14, 2024

FYI @jcsherin

Thank you

@alamb alamb merged commit 4ceb950 into apache:main Oct 14, 2024
24 checks passed
hailelagi pushed a commit to hailelagi/datafusion that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-export PartitionEvaluatorArgs
5 participants