Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Define a protocol for scheme-handling plugins #1479

Merged
merged 1 commit into from
Aug 28, 2024
Merged

refactor: Define a protocol for scheme-handling plugins #1479

merged 1 commit into from
Aug 28, 2024

Commits on Aug 26, 2024

  1. refactor: Define a protocol for scheme handling plugins 

    We don't rely on the protocol itself being implemented by the plugins
(we continue to check with `-respondsToSelector:`) but this allows us to
avoid `objc_msgSend` and provides a way to document some of this plugin
behaviour that is not otherwise explained.

This should also resolve the unsafe plugin iteration issue that was
mentioned in apacheGH-1272 and apacheGH-1030 by always iterating over an array of
plugin objects that is a copy (due to calling `-allValues`).
    @dpogue
    dpogue committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6ba4aca View commit details
    Browse the repository at this point in the history