refactor!: Major API cleanup (WIP) #1454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template's storyboard should handle the initialization of the view controller, rather than constructing it manually here.
This has generally always been the case, but it was typed as a UIViewController which resulted in a bunch of casting when you wanted to do something useful with it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1454 +/- ##
=======================================
Coverage 78.35% 78.35%
=======================================
Files 16 16
Lines 1825 1825
=======================================
Hits 1430 1430
Misses 395 395 ☔ View full report in Codecov by Sentry. |
dpogue
force-pushed
the
major-api-cleanup
branch
from
56cff20
to
1f5625f
Compare
Bump min iOS version for template app to 13.0 (due to UISceneDelegate)
dpogue
force-pushed
the
major-api-cleanup
branch
2 times, most recently
from
31145c7
to
ed7a262
Compare
dpogue
force-pushed
the
major-api-cleanup
branch
from
ed7a262
to
6835944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not finished yet!
Platforms affected
iOS
Motivation and Context
Closes #674.
Closes #904.
Closes #920.
Closes #1428.
Description
...
Testing
...
Checklist
(platform)if this change only applies to one platform (e.g.(android))