Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-4061: Use Default Value of 1 For UTF8 Hash #3177

Merged
merged 1 commit into from
Sep 27, 2024
Merged

AVRO-4061: Use Default Value of 1 For UTF8 Hash #3177

merged 1 commit into from
Sep 27, 2024

Conversation

belugabehr
Copy link
Contributor

@belugabehr belugabehr commented Sep 25, 2024 •
edited
Loading

What is the purpose of the change

  • This pull request improves file read performance by using a cacheable hashcode value for empty strings , fixing AVRO-4061

Verifying this change

This change is a trivial rework / code cleanup with small additional test coverage.

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added the Java Pull Requests for Java binding label Sep 25, 2024
@belugabehr
Copy link
Contributor Author

This is for the 1.13 release

martin-g
martin-g approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@belugabehr belugabehr merged commit 1a2d200 into apache:main Sep 27, 2024
8 checks passed
@belugabehr belugabehr deleted the belugabehr/AVRO-4061-master branch September 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
Java Pull Requests for Java binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belugabehr @martin-g