GH-44491: [C++] Static Status draft #44493
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
felipecrv
reviewed
Oct 21, 2024
Comment on lines
+377
to
+378
| if (ARROW_PREDICT_TRUE(state_ == NULL)) return; | ||
| if (ARROW_PREDICT_FALSE(state_->is_static)) return; |
There was a problem hiding this comment.
Probably better to have a single condition here to make it obvious that the rest of the function is the cold code:
if (ARROW_PREDICT_TRUE(state_ == NULL || state_->is_static)) return;
There was a problem hiding this comment.
I agree that this is more obvious for human readers, but I think the priority here is to make it obvious to the compiler that the hottest condition is state_ == NULL, independent of any other consideration
| private: | ||
| struct State { | ||
| StatusCode code; | ||
| std::string msg; | ||
| std::shared_ptr<StatusDetail> detail; | ||
| bool is_static = false; | ||
| }; | ||
| // OK status has a `NULL` state_. Otherwise, `state_` points to | ||
| // a `State` structure containing the error code and message(s) | ||
| State* state_; | ||
|
|
||
| void DeleteState() { |
There was a problem hiding this comment.
Put noexcept here as well for consistency with ~Status() noexcept.
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It'd be convenient to construct placeholder error Status cheaply.
What changes are included in this PR?
Added
bool Status::State::is_staticwhich causes copies to be shallow and skips destruction.Are these changes tested?
Not yet. Also, the main consideration is probably benchmarks to make sure hot paths don't get much slower.
Are there any user-facing changes?
I don't think we want this API to be public