Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44453: [Release] Add shebang to 07-matlab-upload.sh #44454

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 17, 2024

Rationale for this change

Executable scripts should have shebang.

What changes are included in this PR?

Add #!/usr/bin/env bash.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #44453 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 17, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 17, 2024
@assignUser assignUser merged commit 4a7cfd6 into apache:main Oct 17, 2024
6 checks passed
@assignUser assignUser removed the awaiting merge Awaiting merge label Oct 17, 2024
@kou kou deleted the release-07-matlab-upload-shebang branch October 17, 2024 19:53
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4a7cfd6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants