GH-44368: [C++] Use "lib" for generating bundled dependencies even with "clang-cl" #44391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven with "clang-cl" We can use MSVC tool such as "lib" with "clang-cl" build because it's a MSVC like build.
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
+1 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8973278. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to use "clang-cl" for Windows ARM64. We can use MSVC tool such as "lib" for generating bundled dependencies with "clang-cl" build because it's a MSVC like build.
What changes are included in this PR?
Prefer "lib" to
${CMAKE_AR}with "clang-cl" for generating bundled dependencies. It seems that${CMAKE_AR}doesn't generatearrow_bundled_dependencies.lib.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.