-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43519: [Python][CI] Update Python 3.13 rc to final 3.13.0 #44375
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -84,7 +84,7 @@ RUN (if "%python%"=="3.9" setx PYTHON_VERSION "3.9.13" && setx PATH "%PATH%;C:\P | |||||
(if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11" && setx PATH "%PATH%;C:\Python310;C:\Python310\Scripts") & \ | ||||||
(if "%python%"=="3.11" setx PYTHON_VERSION "3.11.9" && setx PATH "%PATH%;C:\Python311;C:\Python311\Scripts") & \ | ||||||
(if "%python%"=="3.12" setx PYTHON_VERSION "3.12.5" && setx PATH "%PATH%;C:\Python312;C:\Python312\Scripts") & \ | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not strictly required but we can update to the latest on chocolatey.
Suggested change
|
||||||
(if "%python%"=="3.13" setx PYTHON_VERSION "3.13.0-rc1" && setx PATH "%PATH%;C:\Python313;C:\Python313\Scripts") | ||||||
(if "%python%"=="3.13" setx PYTHON_VERSION "3.13.0" && setx PATH "%PATH%;C:\Python313;C:\Python313\Scripts") | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
RUN choco install -r -y --pre --no-progress python --version=%PYTHON_VERSION% | ||||||
RUN python -m pip install -U pip setuptools | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,17 +47,11 @@ full_version=${versions[$2]} | |
if [ $platform = "macOS" ]; then | ||
echo "Downloading Python installer..." | ||
|
||
if [ "$version" = "3.13" ] || [ "$version" = "3.13t" ]; | ||
if [ "$(uname -m)" = "x86_64" ] && [ "$version" = "3.9" ]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM, can you also update https://github.com/apache/arrow/pull/44375/files#diff-404e24b955d9320a7b3db90149855e38c86133f626f8b555002212293e79ad80L31 to:
This is the latest with packages ( |
||
then | ||
fname="python-${full_version}rc2-macos11.pkg" | ||
elif [ "$(uname -m)" = "arm64" ] || \ | ||
[ "$version" = "3.10" ] || \ | ||
[ "$version" = "3.11" ] || \ | ||
[ "$version" = "3.12" ]; | ||
then | ||
fname="python-${full_version}-macos11.pkg" | ||
else | ||
fname="python-${full_version}-macosx10.9.pkg" | ||
else | ||
fname="python-${full_version}-macos11.pkg" | ||
fi | ||
wget "https://www.python.org/ftp/python/${full_version}/${fname}" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly required but we can update to the latest on chocolatey.