Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .NET Framework 4.7.2 #44133

Closed
wants to merge 1 commit into from
Closed

Target .NET Framework 4.7.2 #44133

wants to merge 1 commit into from

Conversation

qed-
Copy link
Contributor

@qed- qed- commented Sep 16, 2024

Rationale for this change

Target .Net Framewok 4.7.1 rather than 4.6.1 due to dependency on netstandard2.0

See #41347

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@@ -8,10 +8,10 @@
</PropertyGroup>

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0;net8.0;net462</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net6.0;net8.0;net472</TargetFrameworks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to support net462 in the core Arrow project because it's not yet at end-of-life. The change to net472 should be in Apache.Arrow.Flight.csproj.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 23, 2024
@CurtHagenlocher
Copy link
Contributor

@qed- , I've checked in the equivalent of this change now so I'm going to close this PR. If you feel this decision is in error, please feel free to reopen or resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants