GH-44085: [CI][R] Update Ubuntu version for R force test #44087
Conversation
|
|
|
@jonkeane I did split this into it's own issue/PR so I could iterate and test without the rest of changes for dropping Python 3.8. I will rebase the other PR with those changes once merged. |
| ENV ARROW_PYTHON_VENV /arrow-dev | ||
| COPY python/requirements-build.txt /arrow/python/ | ||
| RUN python3 -m venv ${ARROW_PYTHON_VENV} && \ | ||
| source ${ARROW_PYTHON_VENV}/bin/activate && \ | ||
| pip install -U pip setuptools wheel && \ | ||
| pip install -r arrow/python/requirements-build.txt |
There was a problem hiding this comment.
Am I reading this correctly that this ends up being effectively the same thing as 100-102 below, just into a venv?
There was a problem hiding this comment.
yes, the system Python on Ubuntu 24.04 forces you to pip install into a virtual env. That's why it fails without this.
There was a problem hiding this comment.
Ah, got it. Ok cool. If the tests pass (which they look like they do, this is good to go!)
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1f964fc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We want to update the Ubuntu version to run the R force tests in order to be able to test pyarrow once it drops Python 3.8.
What changes are included in this PR?
Bumping Ubuntu to 24.04 and use virtualenv in order to avoid installing requirements at the system python which fails on newer Ubuntu.
Are these changes tested?
Yes, on CI
Are there any user-facing changes?
No