Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36412: [Python][CI] Fix deprecation warning about day freq alias with latest pandas #44067

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Sep 11, 2024

Rationale for this change

Updating our pandas usage to follow pandas' changes (they are deprecating the "d" alias as alternative for "D")

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit pandas

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 11, 2024
Copy link

Revision: e807ade

Submitted crossbow builds: ursacomputing/crossbow @ actions-a5ba614b1c

Task Status
test-conda-python-3.10-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.8-pandas-1.0-numpy-1.19 GitHub Actions
test-conda-python-3.9-pandas-latest-numpy-latest GitHub Actions

Copy link
Member

@danepitkin danepitkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorisvandenbossche jorisvandenbossche merged commit d6198c0 into apache:main Sep 11, 2024
14 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Sep 11, 2024
@jorisvandenbossche jorisvandenbossche deleted the gh-36412-pandas-depr branch September 11, 2024 17:32
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d6198c0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 97 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…lias with latest pandas (apache#44067)

### Rationale for this change

Updating our pandas usage to follow pandas' changes (they are deprecating the `"d"` alias as alternative for `"D"`)

* GitHub Issue: apache#36412

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants