Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-43956: [C++][Format] Add initial Decimal32/Decimal64 implementations #43957

Merged
merged 56 commits into from
Sep 30, 2024
Merged

GH-43956: [C++][Format] Add initial Decimal32/Decimal64 implementations #43957

merged 56 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. apacheGH-43956: [C++][Format] Add initial Decimal32/Decimal64 impleme… 

    …ntations
    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    50b57b6 View commit details
    Browse the repository at this point in the history

  2. fix linting

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    12896a9 View commit details
    Browse the repository at this point in the history

  3. fixing a build issue

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5e125e0 View commit details
    Browse the repository at this point in the history

  4. add not implemented for new decimal types with pyarrow

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    64aad89 View commit details
    Browse the repository at this point in the history

  5. make conversion explicit instaed of implicit

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f2a46dd View commit details
    Browse the repository at this point in the history

  6. deprecate old decimal, add smallest_decimal, fix tests

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ed3ff00 View commit details
    Browse the repository at this point in the history

  7. fix linting

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    00caa8a View commit details
    Browse the repository at this point in the history

  8. fix implicit cast

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1684403 View commit details
    Browse the repository at this point in the history

  9. update from feedback

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9b28a0e View commit details
    Browse the repository at this point in the history

  10. fix build issue

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6ba84d5 View commit details
    Browse the repository at this point in the history

  11. enable decimal32/64 integration testing

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a510534 View commit details
    Browse the repository at this point in the history

  12. python lint

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    67512e5 View commit details
    Browse the repository at this point in the history

  13. Update cpp/src/arrow/integration/json_internal.cc 

    Co-authored-by: Felipe Oliveira Carvalho <[email protected]>
    @zeroshade @felipecrv
    zeroshade and felipecrv committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    02aea22 View commit details
    Browse the repository at this point in the history

  14. Update cpp/src/arrow/ipc/metadata_internal.cc 

    Co-authored-by: Felipe Oliveira Carvalho <[email protected]>
    @zeroshade @felipecrv
    zeroshade and felipecrv committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    db59d6d View commit details
    Browse the repository at this point in the history

  15. updates from feedback

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ebed805 View commit details
    Browse the repository at this point in the history

  16. pre-commit and fix

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b95d9ba View commit details
    Browse the repository at this point in the history

  17. rebase and fix

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f4b3a81 View commit details
    Browse the repository at this point in the history

  18. ran pre-commit

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5d82818 View commit details
    Browse the repository at this point in the history

  19. Update cpp/src/arrow/type_fwd.h 

    Co-authored-by: Benjamin Kietzman <[email protected]>
    @zeroshade @bkietz
    zeroshade and bkietz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    315579d View commit details
    Browse the repository at this point in the history

  20. updates from feedback and propagation

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5bef850 View commit details
    Browse the repository at this point in the history

  21. more updates from feedback

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    53cf289 View commit details
    Browse the repository at this point in the history

  22. pre-commit linting

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    87a7445 View commit details
    Browse the repository at this point in the history

  23. convert away from deprecated function

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7ad7dbc View commit details
    Browse the repository at this point in the history

  24. pre-commit

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    202df3b View commit details
    Browse the repository at this point in the history

  25. fix test

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    683a789 View commit details
    Browse the repository at this point in the history

  26. changes from feedback for swapendian

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ccbe6ca View commit details
    Browse the repository at this point in the history

  27. fix unit tests

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    91e3c13 View commit details
    Browse the repository at this point in the history

  28. Update cpp/src/arrow/array/builder_dict.h 

    Co-authored-by: Benjamin Kietzman <[email protected]>
    @zeroshade @bkietz
    zeroshade and bkietz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f47a1f4 View commit details
    Browse the repository at this point in the history

  29. fixed test issue in parquet

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    86aa26c View commit details
    Browse the repository at this point in the history

  30. Update cpp/src/arrow/engine/substrait/expression_internal.cc 

    Co-authored-by: Benjamin Kietzman <[email protected]>
    @zeroshade @bkietz
    zeroshade and bkietz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    34493f7 View commit details
    Browse the repository at this point in the history

  31. Update cpp/src/arrow/compute/kernels/hash_aggregate.cc 

    Co-authored-by: Benjamin Kietzman <[email protected]>
    @zeroshade @bkietz
    zeroshade and bkietz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f71303c View commit details
    Browse the repository at this point in the history

  32. updates from feedback

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f276a9e View commit details
    Browse the repository at this point in the history

  33. lint and windows build fix

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3b6d74a View commit details
    Browse the repository at this point in the history

  34. Update cpp/src/arrow/integration/json_internal.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @zeroshade @pitrou
    zeroshade and pitrou committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7ea13c4 View commit details
    Browse the repository at this point in the history

  35. Update cpp/src/arrow/util/basic_decimal.h 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @zeroshade @pitrou
    zeroshade and pitrou committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    295b4c8 View commit details
    Browse the repository at this point in the history

  36. updates from feedback and comments

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a8c0c75 View commit details
    Browse the repository at this point in the history

  37. remove commented out code

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    46c84f1 View commit details
    Browse the repository at this point in the history

  38. ran pre-commit for linting

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4973864 View commit details
    Browse the repository at this point in the history

  39. sumtype and accumulator type for decimals should be consistent

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b7d2bf3 View commit details
    Browse the repository at this point in the history

  40. simplify check

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    512d464 View commit details
    Browse the repository at this point in the history

  41. linting

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8f46e50 View commit details
    Browse the repository at this point in the history

  42. Add tests for Decimal32 and Decimal64

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ae3d8a2 View commit details
    Browse the repository at this point in the history

  43. linting

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bf9eb74 View commit details
    Browse the repository at this point in the history

  44. remove abs from FromReal, only constexpr in C++23 and newer

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2fb271a View commit details
    Browse the repository at this point in the history

  45. simplify a bunch of tests with a generic typed_test

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b44888d View commit details
    Browse the repository at this point in the history

  46. use FromRealApprox

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e2957a9 View commit details
    Browse the repository at this point in the history

  47. static_cast instead of implicit cast

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    980d6fb View commit details
    Browse the repository at this point in the history

  48. remove special cases, adjust tests

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2a3e5c4 View commit details
    Browse the repository at this point in the history

  49. Update cpp/src/arrow/util/decimal.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @zeroshade @pitrou
    zeroshade and pitrou committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c723754 View commit details
    Browse the repository at this point in the history

  50. more updates from comments

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5382eb4 View commit details
    Browse the repository at this point in the history

  51. add reference to issue for decimal32 approx

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9fda783 View commit details
    Browse the repository at this point in the history

  52. make RoundedRightShift a no-op

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    af8c722 View commit details
    Browse the repository at this point in the history

  53. fix tests

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    48639e3 View commit details
    Browse the repository at this point in the history

  54. avoid ASAN issue

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b110605 View commit details
    Browse the repository at this point in the history

  55. fix ubsan test

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1d97e27 View commit details
    Browse the repository at this point in the history

  56. fix ubsan

    @zeroshade
    zeroshade committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    39032f2 View commit details
    Browse the repository at this point in the history