Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39982: [Java] Add RunEndEncodedVector #43888

Merged
merged 18 commits into from
Sep 20, 2024
Merged

Conversation

ViggoC
Copy link
Contributor

@ViggoC ViggoC commented Aug 29, 2024

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@ViggoC ViggoC marked this pull request as ready for review September 11, 2024 16:09
*/
@Override
public void setNull(int index) {
throw new UnsupportedOperationException(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we could splice the child, but let's ignore that for now

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Sep 12, 2024
Co-authored-by: David Li <[email protected]>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 12, 2024
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one small thing.

@vibhatha do you want to take a look as well?

int rightLogicalIndex = range.getRightStart();

while (leftLogicalIndex < leftRangeEnd) {
int leftPhysicalIndex = leftVector.getPhysicalIndex(leftLogicalIndex);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can file a new issue for it and leave a TODO here.

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting review Awaiting review and removed awaiting change review Awaiting change review awaiting review Awaiting review awaiting merge Awaiting merge labels Sep 18, 2024
@github-actions github-actions bot added the awaiting changes Awaiting changes label Sep 20, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 20, 2024
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Sep 20, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Sep 20, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Sep 20, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Sep 20, 2024
@lidavidm lidavidm merged commit 7d96d94 into apache:main Sep 20, 2024
14 checks passed
@lidavidm lidavidm removed the awaiting changes Awaiting changes label Sep 20, 2024
@ViggoC
Copy link
Contributor Author

ViggoC commented Sep 20, 2024

@lidavidm @vibhatha Thank you for your helps on my first PR of arrow.

@ViggoC ViggoC deleted the viggo/java-ree branch September 20, 2024 05:53
@vibhatha
Copy link
Collaborator

@ViggoC thanks for getting this PR to the finish line.

Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7d96d94.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants