Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41951: [Java] Add @FormatMethod annotations #43376

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

laurentgo
Copy link
Collaborator

@laurentgo laurentgo commented Jul 22, 2024

What changes are included in this PR?

Annotate several methods using format-like string with error-prone @FormatMethod and @FormatString annotations.

Update error-prone version to 2.29.2 and remove unused error-prone javac version property.

Are these changes tested?

CI/CD

Are there any user-facing changes?

None

Annotate several methods using format-like string with error-prone
@FormatMethod and @FormatString annotations

Update error-prone version to 2.29.2 and remove unused error-prone javac
version property
@laurentgo laurentgo requested a review from lidavidm as a code owner July 22, 2024 22:29
Copy link

⚠️ GitHub issue #41951 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm
Copy link
Member

@github-actions crossbow submit -g java

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jul 23, 2024
Copy link

Revision: 721c774

Submitted crossbow builds: ursacomputing/crossbow @ actions-f01d092979

Task Status
java-jars GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@lidavidm lidavidm merged commit 5eea5c9 into apache:main Jul 23, 2024
15 of 16 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jul 23, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5eea5c9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants