GH-43229: [Java] Update Maven project info #43231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Maven modules are missing project information like the website url,
the mailing lists, and scm and issues url
Other may have incorrect links because of the way Maven interpolates
those values at build tim
Update/Fix Maven project information for all modules:
* Add project url, mailing lists, scm and issueManagement information to
bom and maven parent modules
* Fix top-level parent by preventing Maven to rewrite project url, and
scm connections/urls based on the module hierarchy
* Change project.scm.tag to `main` and update version change script to
also change the tag value to `apache-arrow-${version}`
laurentgo
requested review from
assignUser,
kou,
raulcd and
lidavidm
as code owners
|
|
lidavidm
approved these changes
Jul 12, 2024
|
It seems the tests for the version bump fail now, though |
github-actions
bot
added
awaiting merge
|
Yes, a test I didn't know about is failing (which is good, I was worried about the release scripts to not be tested). I will go and fix it |
Add new hunk to check scm tag change
|
@github-actions crossbow submit -g java |
|
Revision: 3760b03 Submitted crossbow builds: ursacomputing/crossbow @ actions-ffaf5df326
|
|
CC @kou for the release scripts |
kou
reviewed
Jul 16, 2024
github-actions
bot
added
awaiting review
github-actions
bot
added
awaiting review
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Jul 17, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit de17643. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
@github-actions crossbow submit -g java-jars |
|
|
@github-actions crossbow submit -g java |
|
Revision: 8cce783 Submitted crossbow builds: ursacomputing/crossbow @ actions-41dd059f6a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some Maven modules are missing project information like the website url, the mailing lists, and scm and issues url
Other may have incorrect links because of the way Maven interpolates those values at build time
What changes are included in this PR?
Update/Fix Maven project information for all modules:
mainand update version change script to also change the tag value toapache-arrow-${version}Are these changes tested?
CI/CD only
Are there any user-facing changes?
No