-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43229: [Java] Update Maven project info #43231
GH-43229: [Java] Update Maven project info #43231
Conversation
Some Maven modules are missing project information like the website url, the mailing lists, and scm and issues url Other may have incorrect links because of the way Maven interpolates those values at build tim Update/Fix Maven project information for all modules: * Add project url, mailing lists, scm and issueManagement information to bom and maven parent modules * Fix top-level parent by preventing Maven to rewrite project url, and scm connections/urls based on the module hierarchy * Change project.scm.tag to `main` and update version change script to also change the tag value to `apache-arrow-${version}`
|
It seems the tests for the version bump fail now, though |
Yes, a test I didn't know about is failing (which is good, I was worried about the release scripts to not be tested). I will go and fix it |
Add new hunk to check scm tag change
@github-actions crossbow submit -g java |
Revision: 3760b03 Submitted crossbow builds: ursacomputing/crossbow @ actions-ffaf5df326 |
CC @kou for the release scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit de17643. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
@github-actions crossbow submit -g java-jars |
|
@github-actions crossbow submit -g java |
Revision: 8cce783 Submitted crossbow builds: ursacomputing/crossbow @ actions-41dd059f6a |
Rationale for this change
Some Maven modules are missing project information like the website url, the mailing lists, and scm and issues url
Other may have incorrect links because of the way Maven interpolates those values at build time
What changes are included in this PR?
Update/Fix Maven project information for all modules:
main
and update version change script to also change the tag value toapache-arrow-${version}
Are these changes tested?
CI/CD only
Are there any user-facing changes?
No