MINOR: [Java] Update issue management config in pom.xml #43191
Conversation
| @@ -81,8 +81,8 @@ under the License. | |||
| </scm> | |||
|
|
|||
| <issueManagement> | |||
| <system>Jira</system> | |||
| <url>https://issues.apache.org/jira/browse/arrow</url> | |||
| <system>GitHub</system> | |||
There was a problem hiding this comment.
Because maven/pom.xml and bom/pom.xml do not inherit from the top-level pom.xml. you may want to change those as well (note that maven/pom.xml is being removed as part of #43139)
There was a problem hiding this comment.
Great catch, I didn't think to look for other uses.
There was a problem hiding this comment.
Turns out we don't populate <issueManagement> in the other poms. Is it typical to add it?
There was a problem hiding this comment.
I am actually not sure whether we need this?
cc @lidavidm
There was a problem hiding this comment.
It's clearly not strictly necessary, so I'd rather we just take the update here?
There was a problem hiding this comment.
Not necessary but nice to have. It may be used by tools and shows up in the site generated by Maven or also accessible from websites like Maven Central.
You can check and compare the pages for arrow-memory-core and arrow-bom
There was a problem hiding this comment.
Looks like Project URL and Source Control are also not configured correctly for maven central. Thanks for sharing.
github-actions
bot
added
awaiting committer review
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8fc40fc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Update the issue management config in Java's parent pom. ### What changes are included in this PR? * Change issue management config from Jira to GitHub ### Are these changes tested? n/a Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Update the issue management config in Java's parent pom.
What changes are included in this PR?
Are these changes tested?
n/a