-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41668: [C++] Support cast kernel from list-like to (large) string #41831
Open
llama90
wants to merge
12
commits into
apache:main
Choose a base branch
from
llama90:ARROW-41668
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
361d6bc
support cast from list-like to string
llama90 2e72e87
add test for FSL, List and Map to String
llama90 a6d9955
update code by self-review
llama90 e9db2c3
apply lint
llama90 c837a79
add test for large string (large_utf8())
llama90 0cee655
rollback
llama90 e3d775d
update unit test for map
llama90 61351b4
update unit test for cast from map to string
llama90 37b6457
rename test
llama90 1a076c8
add TestCastToString class to reuse CheckCastToString function
llama90 affc2cf
use TestCastToString class for FSL and List
llama90 f120585
update ListToString test case for large_list, list_view, and large_li…
llama90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as
TestMapScalar
was written forMapType
, I wanted to write similar classes forList
andFixedSizeList
.However, I found it too extensive to address within this PR, so I only covered
MapType
.It would be better to create a separate issue to handle this.