Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-39565: [C++] Do not concatenate chunked values of fixed-width types to run "array_take" #41700

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

GH-39565: [C++] Do not concatenate chunked values of fixed-width types to run "array_take" #41700

wants to merge 20 commits into from
+935 −217

Commits on Oct 7, 2024

  1. Take: Add VectorKernel::ChunkedExec to SelectionKernelData

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    844aa5e View commit details
    Browse the repository at this point in the history

  2. Take: VectorKernel::output_chunked should be false for "array_take" 

    We will ensure "array_take" returns a ChunkedArray if at least one input
is chunked, just like "take" does. Even when the output fits in a single
chunk.
    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9797c9f View commit details
    Browse the repository at this point in the history

  3. Take: Make "array_take" handle CA->C cases by populating VectorKernel… 

    …::exec_chunked

Before this commit, only the "take" meta function could handle CA
parameters.
    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a135471 View commit details
    Browse the repository at this point in the history

  4. gather_internal.h: Introduce GatherFromChunks

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    36b69af View commit details
    Browse the repository at this point in the history

  5. Take: Introduce ValueSpan to delay dispatching on chunked-ness

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d4b48a3 View commit details
    Browse the repository at this point in the history

  6. Take: Implement the FixedWidthTakeChunkedExec() kernel using GatherFr… 

    …omChunks
    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3435bd5 View commit details
    Browse the repository at this point in the history

  7. Take: Adapt kernel to the ChunkResolver changes

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    40f2422 View commit details
    Browse the repository at this point in the history

  8. TakeMetaFunction: Update comment about what the MetaFunction does

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    022f6a0 View commit details
    Browse the repository at this point in the history

  9. Take: Support CA->C and CC->C cases directly in "array_take" with 2 s… 

    …trategies
    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7f1bc10 View commit details
    Browse the repository at this point in the history

  10. Take: Simplify TakeMetaFunction even further

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ace70fb View commit details
    Browse the repository at this point in the history

  11. Remove all ARROW_NOINLINE from vector_selection_take_internal.cc

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4a48d3e View commit details
    Browse the repository at this point in the history

  12. gather_intenal.h: Clarify the semantics of ValiditySpan/IsSrcValid

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    49b5e97 View commit details
    Browse the repository at this point in the history

  13. Take: Fix silly mistake

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    575d6df View commit details
    Browse the repository at this point in the history

  14. Small fixes from PR feedback

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d47462e View commit details
    Browse the repository at this point in the history

  15. Take: Use fixed size blocks of locations when running TakeCA

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    566a113 View commit details
    Browse the repository at this point in the history

  16. Take: Lazily build a ChunkResolver from ValuesSpan 

    This is not a time-saver yet because in TakeCC kernels, every call to
TakeCA will create a new ValuesSpan instance, but this will change in
the next commits.
    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    408b4d8 View commit details
    Browse the repository at this point in the history

  17. Take: Move the ValuesSpan class to the header

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e638991 View commit details
    Browse the repository at this point in the history

  18. Selection: Fix UB -- nothing guarantees these references to spans are… 

    … stable
    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    54d410d View commit details
    Browse the repository at this point in the history

  19. Selection: Make sub-classes constructable with ValueSpan and ArraySpan's

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3140ceb View commit details
    Browse the repository at this point in the history

  20. Take: Create a signature for Take kernels support AAA and CAA calls

    @felipecrv
    felipecrv committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    018320d View commit details
    Browse the repository at this point in the history