-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39565: [C++] Do not concatenate chunked values of fixed-width types to run "array_take" #41700
Open
felipecrv
wants to merge
20
commits into
apache:main
Choose a base branch
from
felipecrv:take_chunked_fixed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+935
−217
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 844aa5e - Browse repository at this point
Copy the full SHA 844aa5eView commit details -
Take: VectorKernel::output_chunked should be false for "array_take"
We will ensure "array_take" returns a ChunkedArray if at least one input is chunked, just like "take" does. Even when the output fits in a single chunk.
Configuration menu - View commit details
-
Copy full SHA for 9797c9f - Browse repository at this point
Copy the full SHA 9797c9fView commit details -
Take: Make "array_take" handle CA->C cases by populating VectorKernel…
…::exec_chunked Before this commit, only the "take" meta function could handle CA parameters.
Configuration menu - View commit details
-
Copy full SHA for a135471 - Browse repository at this point
Copy the full SHA a135471View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b69af - Browse repository at this point
Copy the full SHA 36b69afView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4b48a3 - Browse repository at this point
Copy the full SHA d4b48a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3435bd5 - Browse repository at this point
Copy the full SHA 3435bd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f2422 - Browse repository at this point
Copy the full SHA 40f2422View commit details -
Configuration menu - View commit details
-
Copy full SHA for 022f6a0 - Browse repository at this point
Copy the full SHA 022f6a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f1bc10 - Browse repository at this point
Copy the full SHA 7f1bc10View commit details -
Configuration menu - View commit details
-
Copy full SHA for ace70fb - Browse repository at this point
Copy the full SHA ace70fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a48d3e - Browse repository at this point
Copy the full SHA 4a48d3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49b5e97 - Browse repository at this point
Copy the full SHA 49b5e97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 575d6df - Browse repository at this point
Copy the full SHA 575d6dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d47462e - Browse repository at this point
Copy the full SHA d47462eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 566a113 - Browse repository at this point
Copy the full SHA 566a113View commit details -
Take: Lazily build a ChunkResolver from ValuesSpan
This is not a time-saver yet because in TakeCC kernels, every call to TakeCA will create a new ValuesSpan instance, but this will change in the next commits.
Configuration menu - View commit details
-
Copy full SHA for 408b4d8 - Browse repository at this point
Copy the full SHA 408b4d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e638991 - Browse repository at this point
Copy the full SHA e638991View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54d410d - Browse repository at this point
Copy the full SHA 54d410dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3140ceb - Browse repository at this point
Copy the full SHA 3140cebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 018320d - Browse repository at this point
Copy the full SHA 018320dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.