Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38007: [C++] Add VariableShapeTensor implementation #38008

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

GH-38007: [C++] Add VariableShapeTensor implementation #38008

wants to merge 62 commits into from

Commits on Sep 11, 2024

  1. Initial commit

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ed51aeb View commit details
    Browse the repository at this point in the history

  2. Python wrapper

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6af58b1 View commit details
    Browse the repository at this point in the history

  3. Add VariableShapeTensorArray::ToTensor(i)

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    15ebefd View commit details
    Browse the repository at this point in the history

  4. :Add ragged_dimensions

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    511d687 View commit details
    Browse the repository at this point in the history

  5. Replace ragged_dimensions with uniform_dimensions

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    96f2dec View commit details
    Browse the repository at this point in the history

  6. Add example for explanation

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1e2eef6 View commit details
    Browse the repository at this point in the history

  7. Add uniform_shape parameter

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d0a2651 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Joris Van den Bossche <[email protected]>
    @rok @jorisvandenbossche
    rok and jorisvandenbossche committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3c93765 View commit details
    Browse the repository at this point in the history

  9. Post rebase

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9273986 View commit details
    Browse the repository at this point in the history

  10. Remove uniform_dimensions, fix python test

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a09c1bd View commit details
    Browse the repository at this point in the history

  11. lint

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f24fa7d View commit details
    Browse the repository at this point in the history

  12. uniform_shape values are optional

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    935c84b View commit details
    Browse the repository at this point in the history

  13. Add scalar test

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7652d6d View commit details
    Browse the repository at this point in the history

  14. Create Tensor from scalar

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    522fa59 View commit details
    Browse the repository at this point in the history

  15. Move get_tensor logic to cpp

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    831c99d View commit details
    Browse the repository at this point in the history

  16. slice buffer with array offset

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1da9790 View commit details
    Browse the repository at this point in the history

  17. Update cpp/src/arrow/extension/variable_shape_tensor.h 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2edf17b View commit details
    Browse the repository at this point in the history

  18. Update cpp/src/arrow/extension/variable_shape_tensor.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    95eea74 View commit details
    Browse the repository at this point in the history

  19. Update cpp/src/arrow/extension/variable_shape_tensor.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7b0ab6c View commit details
    Browse the repository at this point in the history

  20. Update cpp/src/arrow/extension/variable_shape_tensor.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    58e9365 View commit details
    Browse the repository at this point in the history

  21. Update cpp/src/arrow/extension/variable_shape_tensor.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ae3a5c6 View commit details
    Browse the repository at this point in the history

  22. Review feedback

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9a90eb1 View commit details
    Browse the repository at this point in the history

  23. Update cpp/src/arrow/extension/variable_shape_tensor.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    75019c8 View commit details
    Browse the repository at this point in the history

  24. Review feedback

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    585699d View commit details
    Browse the repository at this point in the history

  25. import and uint32->int32

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b3945eb View commit details
    Browse the repository at this point in the history

  26. permutation check

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f2e33a2 View commit details
    Browse the repository at this point in the history

  27. Remove serialization from cython, lint

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d569a2d View commit details
    Browse the repository at this point in the history

  28. Review feedback

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4ec4039 View commit details
    Browse the repository at this point in the history

  29. ndim initializer

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5d52992 View commit details
    Browse the repository at this point in the history

  30. Test null values

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    58ab37c View commit details
    Browse the repository at this point in the history

  31. Remove one GetTensor code paths, permutation handling

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8177874 View commit details
    Browse the repository at this point in the history

  32. Allow arbitrary memory layout

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e75905c View commit details
    Browse the repository at this point in the history

  33. fix permutation check

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    86c6931 View commit details
    Browse the repository at this point in the history

  34. lint

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c59e7dd View commit details
    Browse the repository at this point in the history

  35. lint

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    567e483 View commit details
    Browse the repository at this point in the history

  36. roundtrip strided

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    76b113e View commit details
    Browse the repository at this point in the history

  37. Apply suggestions from code review 

    Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
    @rok @pitrou @jorisvandenbossche
    3 people committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6ba0369 View commit details
    Browse the repository at this point in the history

  38. remove array.gettensor, simlify

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e67c3a2 View commit details
    Browse the repository at this point in the history

  39. work

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    09afbc5 View commit details
    Browse the repository at this point in the history

  40. Add repr

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f9aaa28 View commit details
    Browse the repository at this point in the history

  41. Review feedback

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a9684ee View commit details
    Browse the repository at this point in the history

  42. GetTensor->MakeTensor, static

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f178e4b View commit details
    Browse the repository at this point in the history

  43. Better permutations check

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    80cc733 View commit details
    Browse the repository at this point in the history

  44. post rebase changes

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    252a643 View commit details
    Browse the repository at this point in the history

  45. work

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    39e89eb View commit details
    Browse the repository at this point in the history

  46. ToString new parameter

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7476321 View commit details
    Browse the repository at this point in the history

  47. Remove Python bindings

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c9dd006 View commit details
    Browse the repository at this point in the history

  48. Review feedback

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b716708 View commit details
    Browse the repository at this point in the history

  49. Use TensorFromJSON

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    977d19a View commit details
    Browse the repository at this point in the history

  50. lint

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0e113ac View commit details
    Browse the repository at this point in the history

  51. Apply suggestions from code review 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    33ceee6 View commit details
    Browse the repository at this point in the history

  52. Update cpp/src/arrow/extension/variable_shape_tensor.cc 

    Co-authored-by: Antoine Pitrou <[email protected]>
    @rok @pitrou
    rok and pitrou committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    26b7698 View commit details
    Browse the repository at this point in the history

  53. fix

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b49021e View commit details
    Browse the repository at this point in the history

  54. Review feedback

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8c2f0a3 View commit details
    Browse the repository at this point in the history

  55. mingw64 issue

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aa3d29a View commit details
    Browse the repository at this point in the history

  56. refactor ComputeStrides

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3741041 View commit details
    Browse the repository at this point in the history

  57. Change to ComputeStrides

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    dfd5fbe View commit details
    Browse the repository at this point in the history

  58. Change ToTensor

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    341757b View commit details
    Browse the repository at this point in the history

  59. Refactoring ComputeStrides

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    64d73fb View commit details
    Browse the repository at this point in the history

  60. Move RoundtripBatch to gtest_util.cc

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c3dab58 View commit details
    Browse the repository at this point in the history

  61. Post rebase changes

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2cfc678 View commit details
    Browse the repository at this point in the history

  62. Post rebase changes

    @rok
    rok committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f391ab6 View commit details
    Browse the repository at this point in the history