GH-37988: [Format] Add VariableShapeTensor canonical extension type definition #37992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Documentation
awaiting committer review
|
@rok I would maybe suggest doing it the other way around: make a separate PR for the implementation, and keep #37166 for the format specification, because all discussion about the format happened already on that PR (essentially all discussion there was about the spec, and not yet about the implementation) |
|
@jorisvandenbossche that's a fair point, I'll do that. |
|
Closing in favor of #38008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We want to add a canonical extension type definition for arrays containing tensors with variable shapes.
What changes are included in this PR?
This amends canonical extensions list in documentation.
Are these changes tested?
Proposed changes are not tested as they are only for documentation. Proposed type is implemented and tested in #37166.
Are there any user-facing changes?
Through documentation only.