GH-34620: [C#] Support DateOnly and TimeOnly on .NET 6.0+ #36125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
westonpace
requested changes
Jul 17, 2023
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
westonpace
approved these changes
Jul 19, 2023
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this pull request
Jul 20, 2023
…he#36125) ### What changes are included in this PR? Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later. Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later. A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types. ### Are these changes tested? Yes * Closes: apache#34620 Authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: Weston Pace <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit bebd2bf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
…he#36125) ### What changes are included in this PR? Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later. Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later. A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types. ### Are these changes tested? Yes * Closes: apache#34620 Authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: Weston Pace <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…he#36125) ### What changes are included in this PR? Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later. Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later. A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types. ### Are these changes tested? Yes * Closes: apache#34620 Authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: Weston Pace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later.
Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later.
A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types.
Are these changes tested?
Yes
DateOnlyandTimeOnlyvalues on .NET 6. #34620