GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+

[danepitkin]

Rationale for this change

Now that Arrow Java has moved from Java 8 -> Java 11, we need to add --add-opens when running Java.

What changes are included in this PR?

• Add --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED to _JAVA_OPTIONS in archery.
• Clean up test code only used for Java 8

Are these changes tested?

To be verified via CI and ursabot.

Are there any user-facing changes?

No

• GitHub Issue: [Java][Benchmarking] Java benchmarks are broken when running with Java 17+ #43394

[github-actions]

⚠️ GitHub issue #43394 has been automatically assigned in GitHub to PR creator.

[danepitkin]

@ursabot please benchmark lang=Java

[ursabot]

Benchmark runs are scheduled for commit 3b8b942. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

[danepitkin]

Benchmark run is successful: https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-m5-4xlarge-us-east-2/builds/5025

[vibhatha]

Thanks @danepitkin, PR LGTM.

[vibhatha]

@danepitkin shall we run the crossbows as well?

[danepitkin]

@github-actions crossbow submit -g java

[danepitkin]

Thanks @vibhatha!

[github-actions]

Revision: 3b8b942

Submitted crossbow builds: ursacomputing/crossbow @ actions-4f8795faaf

Task	Status
java-jars
test-conda-python-3.11-spark-master
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

[conbench-apache-arrow]

Thanks for your patience. Conbench analyzed the 2 benchmarking runs that have been run so far on PR commit 3b8b942.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a49dbcc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.