Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][Benchmarking] Java benchmarks are broken when running with Java 17+ #43394

Closed
danepitkin opened this issue Jul 23, 2024 · 1 comment
Closed

[Java][Benchmarking] Java benchmarks are broken when running with Java 17+ #43394

danepitkin opened this issue Jul 23, 2024 · 1 comment
Assignees
@danepitkin
Labels
Component: Java Type: bug
Milestone
18.0.0

Comments

@danepitkin
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

See benchmark report https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-c6a-4xlarge-us-east-2/builds/202#0190df7f-d82d-4128-b98b-42b30daf2d02/6-10332

We need to add --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED when running benchmarks.

Component(s)

Java
danepitkin added a commit to danepitkin/arrow that referenced this issue Jul 23, 2024
@danepitkin
apacheGH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+
3c434ae
@github-actions github-actions bot mentioned this issue Jul 23, 2024
Merged
danepitkin added a commit that referenced this issue Jul 24, 2024
@danepitkin
GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+ (#43395)
a49dbcc 
### Rationale for this change

Now that Arrow Java has moved from Java 8 -> Java 11, we need to add `--add-opens` when running Java.

### What changes are included in this PR?

* Add `--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` to `_JAVA_OPTIONS` in archery.
* Clean up test code only used for Java 8

### Are these changes tested?

To be verified via CI and ursabot.

### Are there any user-facing changes?

No
* GitHub Issue: #43394

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Dane Pitkin <[email protected]>
@danepitkin danepitkin added this to the 18.0.0 milestone Jul 24, 2024
@danepitkin
Copy link
Member Author

Issue resolved by pull request 43395
#43395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danepitkin danepitkin

Labels
Component: Java Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@danepitkin