-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43320: [Java] fix for SchemaChangeRuntimeException transferring empty FixedSizeListVector #43321
Conversation
|
java/vector/src/test/java/org/apache/arrow/vector/TestFixedSizeListVector.java
Show resolved
Hide resolved
There is a formatting error, this should have failed when compiling locally? |
java/vector/src/test/java/org/apache/arrow/vector/TestFixedSizeListVector.java
Show resolved
Hide resolved
Adding a test case to check the mentioned steps in the issue would be better. |
@vibhatha I did
I can, although this test case was a more minimal repro which took DUV out of the loop - it failed before the fix and passed afterwards. |
…mpl.<init>, resolves apache#43320
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit bbfb7b9. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
What changes are included in this PR?
When we create a FSLV through TransferImpl, we check to see if the source's element vector is a ZeroVector and, if not, we don't call addOrGetVector.
Are these changes tested?
Yep - see TestFixedSizeListVector
Are there any user-facing changes?
No
SchemaChangeRuntimeException
in transferred empty FixedSizeListVector #43320