Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43320: [Java] fix for SchemaChangeRuntimeException transferring empty FixedSizeListVector #43321

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jarohen
Copy link
Contributor

@jarohen jarohen commented Jul 18, 2024

What changes are included in this PR?

When we create a FSLV through TransferImpl, we check to see if the source's element vector is a ZeroVector and, if not, we don't call addOrGetVector.

Are these changes tested?

Yep - see TestFixedSizeListVector

Are there any user-facing changes?

No

@jarohen jarohen requested a review from lidavidm as a code owner July 18, 2024 10:13
Copy link

⚠️ GitHub issue #43320 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jul 18, 2024
@vibhatha
Copy link
Collaborator

There is a formatting error, this should have failed when compiling locally? mvn spotless:apply

@vibhatha
Copy link
Collaborator

Adding a test case to check the mentioned steps in the issue would be better.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jul 18, 2024
@jarohen
Copy link
Contributor Author

jarohen commented Jul 18, 2024

There is a formatting error, this should have failed when compiling locally? mvn spotless:apply

@vibhatha I did mvn -pl vector test which passed (although we're based atop the 17.0.0 release tag, so it might have changed in the meantime). In any event, will fix this up 🙏

Adding a test case to check the mentioned steps in the issue would be better.

I can, although this test case was a more minimal repro which took DUV out of the loop - it failed before the fix and passed afterwards.

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 18, 2024
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jul 19, 2024
@lidavidm lidavidm merged commit bbfb7b9 into apache:main Jul 19, 2024
15 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jul 19, 2024
Copy link

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit bbfb7b9.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@jarohen jarohen deleted the java-fslv-43320 branch July 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants