Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] SchemaChangeRuntimeException in transferred empty FixedSizeListVector #43320

Closed
jarohen opened this issue Jul 18, 2024 · 1 comment
Closed

[Java] SchemaChangeRuntimeException in transferred empty FixedSizeListVector #43320

jarohen opened this issue Jul 18, 2024 · 1 comment
Assignees
@jarohen
Labels
Component: Java Type: bug
Milestone
18.0.0

Comments

@jarohen
Copy link
Contributor

jarohen commented Jul 18, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Yep, it's a bit obscure, this one 😅

Arrow 17.0.0

Steps:

  1. Create a FixedSizeListVector (FSLV), it initialises with a ZeroVector for its elements.
  2. Add it to a dense-union through DUV.addVector
  3. That method transfers the empty FSLV through DUV.addVector but, in doing so, it creates a NullVector in the new vector rather than a ZeroVector.
  4. Trying to set the element vector using FSLV.addOrGetVector throws SchemaChangeRuntimeException, because it explicitly checks for ZeroVector.

Will submit a test case and a fix shortly in a PR 🙂

Component(s)

Java
jarohen added a commit to xtdb/arrow that referenced this issue Jul 18, 2024
@jarohen
fix for SchemaChangeRuntimeException in FixedSizeListVector.TransferI…
79a19c9 
…mpl.<init>, resolves apache#43320
jarohen added a commit to xtdb/arrow that referenced this issue Jul 18, 2024
@jarohen
fix for SchemaChangeRuntimeException in FixedSizeListVector.TransferI…
f466d25 
…mpl.<init>, resolves apache#43320
@github-actions github-actions bot mentioned this issue Jul 18, 2024
Merged
jarohen added a commit to xtdb/xtdb that referenced this issue Jul 18, 2024
@jarohen
including fix for apache/arrow#43320
0c018ba
jarohen added a commit to xtdb/arrow that referenced this issue Jul 18, 2024
@jarohen
fix for SchemaChangeRuntimeException in FixedSizeListVector.TransferI…
1a51b55 
…mpl.<init>, resolves apache#43320
lidavidm pushed a commit that referenced this issue Jul 19, 2024
@jarohen
GH-43320: [Java] fix for SchemaChangeRuntimeException transferring em…
bbfb7b9 
…pty FixedSizeListVector (#43321)

### What changes are included in this PR?

When we create a FSLV through TransferImpl, we check to see if the source's element vector is a ZeroVector and, if not, we don't call addOrGetVector.

### Are these changes tested?

Yep - see TestFixedSizeListVector

### Are there any user-facing changes?

No
* GitHub Issue: #43320

Authored-by: James Henderson <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm
Copy link
Member

Issue resolved by pull request 43321
#43321

@lidavidm lidavidm added this to the 18.0.0 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarohen jarohen

Labels
Component: Java Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@lidavidm @jarohen