Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] gRPC fails to build when I'm building Flight without GCS #43218

Closed
felipecrv opened this issue Jul 11, 2024 · 1 comment
Closed

[C++] gRPC fails to build when I'm building Flight without GCS #43218

felipecrv opened this issue Jul 11, 2024 · 1 comment
Assignees
Milestone

Comments

@felipecrv
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

 38 || /opt/homebrew/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -I/Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc_ep/include -I/Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc_ep -I/Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc_ep/third_party/address_sorting/include -I/Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc
    _ep/src/core/ext/upb-generated -I/Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc_ep/src/core/ext/upbdefs-generated -I/Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc_ep/third_party/upb -I/Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc_ep/third_party/xxhash -isystem /opt/homebrew/opt/openssl@3/include -isystem /opt/homebrew/include -Qunused-arguments -fcolor-diagnostics -fPIC -Wno-a
    ttributes -Wno-format-security -Wno-unknown-warning-option  -g -Werror -O0 -ggdb   -Wno-error -std=c++17 -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -MD -MT CMakeFiles/grpc.dir/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc.o -MF CMakeFiles/grpc.dir/src/core/ext/filters/client_channel/resolver/binder/binder_
    resolver.cc.o.d -o CMakeFiles/grpc.dir/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc.o -c /Users/felipe/code/arrow/cpp/ninja/grpc_ep-prefix/src/grpc_ep/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc
 39 cpp/ninja/grpc_ep-prefix/src/grpc_ep/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc|94 col 17| error: no member named 'StrCat' in namespace 'absl'
 40 ||           absl::StrCat(path, " is too long to be handled"));
 41 ||           ~~~~~~^

It was not clear to me why this was happening (no matter the -Dabsl_SOURCE I set while having abseil installed on the system).

I tried to debug the build code but ensure_absl's body nested under lots of conditions wasn't getting hit while configuring the build.

Component(s)

C++

@felipecrv felipecrv self-assigned this Jul 11, 2024
kou added a commit that referenced this issue Jul 12, 2024
… system (#43219)

### Rationale for this change

The workarounds around Abseil resolution don't seem necessary anymore and they don't work on all possible configurations of the build.

### What changes are included in this PR?

Removal of the `ensure_absl` macro and adding a call to `resolve_dependency` when depending on the Google Cloud SDK (a GCS filesystem dependency) or gRPC (a flight dependency).

### Are these changes tested?

Yes, by me trying different build configurations on my macOS and existing builds in CI.

* GitHub Issue: #43218

Lead-authored-by: Felipe Oliveira Carvalho <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Jul 12, 2024
@kou
Copy link
Member

kou commented Jul 12, 2024

Issue resolved by pull request 43219
#43219

@kou kou closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants