-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41668: [C++] Support cast kernel from list-like to (large) string #41831
base: main
Are you sure you want to change the base?
Conversation
The reason for handling these types in a PR.
classDiagram
NestedType <|-- BaseListType
BaseListType <|-- ListType
BaseListType <|-- LargeListType
BaseListType <|-- ListViewType
BaseListType <|-- LargeListViewType
BaseListType <|-- FixedSizeListType
ListType <|-- MapType
|
} | ||
} | ||
|
||
class TestMapScalar : public TestCastToString { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as TestMapScalar
was written for MapType
, I wanted to write similar classes for List
and FixedSizeList
.
However, I found it too extensive to address within this PR, so I only covered MapType
.
It would be better to create a separate issue to handle this.
@felipecrv Would you like to take a look at this (potentially stale) PR? |
I have wrote a series of comments (in #41827) explaining @llama90 that stringfying nested arrays efficiently will require an approach similar to building the hierarchy of builders. I even started building the skeleton of that so that he could continue building formatters for other nested types, but there are some PRs that should be merged before I can push that code (like the stringv-view/string casts). |
@felipecrv Thank you very much for your efforts not only on this issue but also on the related issues. |
Rationale for this change
Support
cast
kernel from list-like (such aslist
,large list
,list view
,large list view
,fixed size list
, andmap
) to (large) stringWhat changes are included in this PR?
cast
kernellist
to (large)string
large list
to (large)string
list view
to (large)string
large list view
to (large)string
fixed size list
to (large)string
map
to (large)string
Are these changes tested?
Yes. It is passed by existing test cases.
Are there any user-facing changes?
No.