-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ARROW-6180: [C++][Parquet] Add RandomAccessFile::GetStream that retur…
…ns InputStream that reads a file segment independent of the file's state, fix concurrent buffered Parquet column reads This enables different functions to read portions of a `RandomAccessFile` as an InputStream without interfering with each other. This also addresses PARQUET-1636 and adds a unit test for buffered column chunk reads. In the refactor to use the Arrow IO interfaces, I broke this by allowing the raw RandomAccessFile to be passed into multiple `BufferedInputStream` at once, so the file position was being manipulated by different column readers. We didn't catch the problem because we didn't have any unit tests, so this patch addresses that deficiency. Closes #5085 from wesm/ARROW-6180 and squashes the following commits: e4ad370 <Wes McKinney> Code review comments 2645bec <Wes McKinney> Add unit test that exhibits PARQUET-1636 76dc71c <Wes McKinney> stub 3eb0136 <Wes McKinney> Finish basic unit tests 4fd3d61 <Wes McKinney> Start implementation Authored-by: Wes McKinney <[email protected]> Signed-off-by: Wes McKinney <[email protected]>
- Loading branch information
Showing
7 changed files
with
262 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.