Skip to content

Commit

Permalink
GH-44044: [Java] Consider warnings as errors for Vector Module (#44045)
Browse files Browse the repository at this point in the history
### Rationale for this change

This PR configs the build such that warnings are considered errors in the Vector module. And corresponding code changes have also been made.

### What changes are included in this PR?

Adding flags to consider warnings as errors in javac and fixing the corresponding errors.

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

N/A
* GitHub Issue: #44044

Authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Signed-off-by: David Li <[email protected]>
  • Loading branch information
vibhatha authored Sep 11, 2024
1 parent e710b6e commit 2c44bcc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
9 changes: 9 additions & 0 deletions java/vector/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,15 @@ under the License.
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration combine.children="append">
<compilerArgs>
<arg>-Werror</arg>
</compilerArgs>
</configuration>
</plugin>
<plugin>
<!-- generate sources from fmpp -->
<groupId>org.apache.drill.tools</groupId>
Expand Down
1 change: 1 addition & 0 deletions java/vector/src/main/codegen/templates/BaseWriter.java
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ public interface StructOrListWriter {
/**
* @deprecated use {@link #listOfStruct()} instead.
*/
@Deprecated
StructOrListWriter listoftstruct(String name);
StructOrListWriter listOfStruct(String name);
StructOrListWriter list(String name);
Expand Down

0 comments on commit 2c44bcc

Please sign in to comment.