Skip to content

Commit

Permalink
MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 10.17.0 to 10…
Browse files Browse the repository at this point in the history
….18.1 in /java Manual (#43980)

### Rationale for this change

The dependabot PR #43922 automated change doesn't fix some code level changes required. This PR fixes that. 

### What changes are included in this PR?

This PR is a supportive PR to enable the `puppycraw.tools:checkstyle` plugin upgrade. 

### Are these changes tested?

Using existing test cases. 

### Are there any user-facing changes?

No

Authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Signed-off-by: David Li <[email protected]>
  • Loading branch information
vibhatha authored Sep 6, 2024
1 parent 5ad0b3e commit 12dddfc
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static Stream<Arguments> getTestData() throws IOException {
Arguments.of(getTable("h2/test1_map_h2.yml", JdbcToArrowMapDataTypeTest.class)));
}

/** Test Method to test JdbcToArrow Functionality for Map form Types.OTHER column */
/** Test Method to test JdbcToArrow Functionality for Map form Types.OTHER column. */
@ParameterizedTest
@MethodSource("getTestData")
public void testJdbcToArrowValues(Table table)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ public void close() throws Exception {
}
}

/** A stream observer for Flight.PutResult */
/** A stream observer for Flight.PutResult. */
private static class SetStreamObserver implements StreamObserver<Flight.PutResult> {
private final BufferAllocator allocator;
private final StreamListener<PutResult> listener;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

/** Test the behavior of ArrowFlightSqlClientHandler.Builder */
/** Test the behavior of ArrowFlightSqlClientHandler.Builder. */
public class ArrowFlightSqlClientHandlerBuilderTest {

@RegisterExtension
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ public byte readByte() {
}

/**
* Read dst.length bytes at readerIndex into dst byte array
* Read dst.length bytes at readerIndex into dst byte array.
*
* @param dst byte array where the data will be written
*/
Expand Down
2 changes: 1 addition & 1 deletion java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ under the License.
<dep.avro.version>1.12.0</dep.avro.version>
<arrow.vector.classifier></arrow.vector.classifier>
<forkCount>2</forkCount>
<checkstyle.version>10.17.0</checkstyle.version>
<checkstyle.version>10.18.1</checkstyle.version>
<checkstyle.failOnViolation>true</checkstyle.failOnViolation>
<error_prone_core.version>2.31.0</error_prone_core.version>
<mockito.core.version>5.11.0</mockito.core.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import org.apache.arrow.flatbuf.MessageHeader;

/**
* POJO wrapper around a Dictionary Batch IPC messages
* POJO wrapper around a Dictionary Batch IPC messages.
* (https://arrow.apache.org/docs/format/IPC.html#dictionary-batches)
*/
public class ArrowDictionaryBatch implements ArrowMessage {
Expand Down

0 comments on commit 12dddfc

Please sign in to comment.