Skip to content

Commit

Permalink
MINOR: [C#] Fix Flight to target net472 intead of net462 (#44258)
Browse files Browse the repository at this point in the history
### Rationale for this change

.NET 4.6.2 is not really netstandard2.0-compatible; it works, but only by bringing in a ridiculous number of facade assemblies. The downlevel web server support for gPRC falls into this category, so bump the required version for Flight from 462 to 472.

### What changes are included in this PR?

Changes the targeting of the build for the C# Arrow Flight support.

### Are these changes tested?

N/A

### Are there any user-facing changes?

The underlying feature is first shipping in Arrow 18 so existing users are unaffected.

Authored-by: Curt Hagenlocher <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
  • Loading branch information
CurtHagenlocher authored Sep 30, 2024
1 parent 6f64af5 commit 0a7db32
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;netstandard2.1;net462</TargetFrameworks>
<TargetFrameworks>netstandard2.0;netstandard2.1;net472</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand All @@ -15,7 +15,7 @@
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)'=='net462'">
<ItemGroup Condition="'$(TargetFramework)'=='net472'">
<PackageReference Include="Grpc.Core" Version="2.46.6" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#if NET46_OR_GREATER
#if NET47_OR_GREATER

using Apache.Arrow.Flight.Protocol;
using Apache.Arrow.Flight.Server.Internal;
Expand Down

0 comments on commit 0a7db32

Please sign in to comment.