Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go/adbc/driver/flightsql): add context to gRPC errors #921

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat(go/adbc/driver/flightsql): add context to gRPC errors #921

merged 1 commit into from
Jul 20, 2023

Conversation

lidavidm
Copy link
Member

See #862.

Example:

Internal: SqlState: , msg: [FlightSQL] Ballista Error: General("scheduler::from_proto(Action) invalid or missing action") (Internal; DoGet: endpoint 0: [uri:"grpc+tcp://172.24.0.5:50051"])

Now we can see that the error comes from issuing a DoGet against a particular location.

@lidavidm lidavidm requested a review from zeroshade as a code owner July 20, 2023 15:08
@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Jul 20, 2023
zeroshade
zeroshade approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nothing stands out as inherently problematic

@lidavidm lidavidm merged commit 6263cfd into apache:main Jul 20, 2023
44 checks passed
@lidavidm lidavidm deleted the gh-862-error-context branch July 20, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lidavidm @zeroshade