feat(c): Implement ingestion and testing for float16, string_view, and binary_view #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Oct 8, 2024
| @@ -263,6 +267,11 @@ void StatementTest::TestSqlIngestLargeString() { | |||
| NANOARROW_TYPE_LARGE_STRING, {std::nullopt, "", "", "1234", "例"}, false)); | |||
| } | |||
|
|
|||
| void StatementTest::TestSqlIngestStringView() { | |||
| ASSERT_NO_FATAL_FAILURE(TestSqlIngestType<std::string>( | |||
| NANOARROW_TYPE_STRING_VIEW, {std::nullopt, "", "", "1234", "例"}, false)); | |||
There was a problem hiding this comment.
Not sure how much this affects the test suite, but probably good to add a string here that will exceed the inline size (maybe even as a separate test)
lidavidm
approved these changes
Oct 8, 2024
paleolimbot
force-pushed
the
c-driver-ingest-more-types
branch
from
89eb44b
to
e6c854e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests ingestion of half float, string view, and binary view, for which support was added between nanoarrow 0.5.0 and nanoarrow 0.6.0. It also removes some skips for various combinations of numeric types for which support was already available that I missed when adding support for those types.