refactor(c/driver/postgresql): Use GetObjectsHelper from framework to build objects #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
force-pushed
the
c-driver-postgres-objects-helper
branch
from
dce3aec
to
2544d30
Compare
paleolimbot
force-pushed
the
c-driver-postgres-objects-helper
branch
from
2544d30
to
2e8332c
Compare
lidavidm
approved these changes
Oct 18, 2024
WillAyd
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the PostgreSQL driver to use the same
GetObjectsHelperas the SQLite driver (the one provided by the framework). This involved a few updates to the helper (notably: ensure the filter is passed to theLoadXXX()methods), and an update to the result helper to make it easier to store iteration state along a result as a member of the helper.