feat(go/adbc/driver/flightsql): Improvements for flightSql error details #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use &adbc.ProtobufErrorDetail if the detail can be decoded into proto
zeroshade
changed the title
rshura
changed the title
rshura
changed the title
zeroshade
requested changes
Sep 24, 2024
Comment on lines
+118
to
+120
| if strings.HasPrefix(value, "Grpc-") { | ||
| continue | ||
| } |
There was a problem hiding this comment.
why skip things with Grpc- prefix?
There was a problem hiding this comment.
I don't know why and how, but I was getting TextErrorDetails with key trailer and value Grpc-Status and Grpc-Message and Grpc-Status-Details-Bin. I don't think those values can be useful.
Comment on lines
+140
to
+142
| if strings.HasPrefix(value, "Grpc-") { | ||
| continue | ||
| } |
lidavidm
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Hmm. Isn't this strictly worse now? Because without any, you have to know the actual Protobuf type in advance.
There was a problem hiding this comment.
Yes it appears so. I guess we can scrap this PR if there's nothing useful.
|
Closing as it seems to not improve anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2179