-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go/adbc/driver/flightsql): Improvements for flightSql error details #2185
Conversation
Use &adbc.ProtobufErrorDetail if the detail can be decoded into proto
if strings.HasPrefix(value, "Grpc-") { | ||
continue | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why skip things with Grpc-
prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why and how, but I was getting TextErrorDetails with key trailer
and value Grpc-Status
and Grpc-Message
and Grpc-Status-Details-Bin
. I don't think those values can be useful.
if strings.HasPrefix(value, "Grpc-") { | ||
continue | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Isn't this strictly worse now? Because without any, you have to know the actual Protobuf type in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it appears so. I guess we can scrap this PR if there's nothing useful.
Closing as it seems to not improve anything. |
See #2179