Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Update Cargo.lock #2042

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paleolimbot
Copy link
Member

I keep accidentally updating Cargo.lock because VSCode's rust-analyzer keeps running cargo update-lockfile whenever I open the workspace. I figured out how to turn this off; however, it is probably a good idea to update it periodically since it embeds a few references to the current version number. I added a step in the version bumping to do this after a release but I'm also happy to remove that if it will cause problems.

@lidavidm
Copy link
Member

lidavidm commented Oct 8, 2024

Want to update this? I agree we should update the lockfile (in fact, maybe we also want that to be one of the Rust CI steps)

@paleolimbot
Copy link
Member Author

I can take a shot at this after the nanoarrow release is cut. What tripped me up when I did this initially is that it introduced a number of clippy lint items and at the time I wasn't able to look into those (but certainly could now).

@lidavidm
Copy link
Member

lidavidm commented Oct 8, 2024

Ah, hopefully the recent PRs have fixed the Clippy lints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants