chore(r/adbcsnowflake): Update adbcsnowflake such that it can be submitted to CRAN #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I think I know why the files have to be modified: I was using the C++ version of helpers.h, and |
|
Most of these problems will go away when the vendored code is downloaded at runtime if needed, but I ran it through winbuilder and: |
|
(CI failures are because https://r-project.org is down which has halted R CI jobs pretty much everywhere.) |
zeroshade
reviewed
Oct 27, 2023
zeroshade
reviewed
Oct 27, 2023
assignUser
approved these changes
Oct 28, 2023
| @@ -17,9 +17,9 @@ Encoding: UTF-8 | |||
| Roxygen: list(markdown = TRUE) | |||
There was a problem hiding this comment.
Is this not missing a lower bound when you mention below that this will not compile on <4.2?
Suggested change
| Roxygen: list(markdown = TRUE) | |
| Depends: R (>= 4.2) | |
| Roxygen: list(markdown = TRUE) |
There was a problem hiding this comment.
I'll try to find that comment to clarify...the 4.2 version constraint is just for Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067.
The mailing list thread where I asked about this ( https://stat.ethz.ch/pipermail/r-package-devel/2023q3/009329.html ) noted a few possible requirements:
file://URL...when submission times come that URL and shasum can be hardwired into the package.I also added some updates to make the tests run with my local Snowflake account and consoliated the Windows and MacOS and Linux builds since the all use the same logic.
This will probably need to be workshopped during submission and, after successful submission, distilled into some common place and applied to the adbcflightsql package.