Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3066] Optimizing the efficiency for optimizing-processes rest api #3257

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

klion26
Copy link
Member

@klion26 klion26 commented Oct 15, 2024

Why are the changes needed?

Close #3066.

Brief change log

  • remove the ServerCatalog#tableExists(db, table) in TableController#getOptimizingProcesses because we can reuse the table load logic in the following logic
  • push the offset and limit in mapper#selectOptimizingProcesses(MixedAndIcebergTableDescriptor#getOptimizingProcessesInfo) to db (this can limit the items retrieved from db)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request
    WeChatWorkScreenshot_b2bc81ed-0dc4-41cc-92bb-f3fd48abde4f
    WeChatWorkScreenshot_5f2c49bd-20a8-4d4e-9218-eba80d441ddd

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@klion26
Copy link
Member Author

klion26 commented Oct 16, 2024

@zhoujinsong @majin1102 could you please have a look when you're free thanks.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!
I left some comments, PTAL.

Copy link
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this contribution.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and validated in my local envirionment.
Thanks for the work! @klion26

@zhoujinsong zhoujinsong merged commit d97597f into apache:master Oct 18, 2024
4 checks passed
@klion26 klion26 deleted the optimizing-process branch October 18, 2024 08:01
@klion26
Copy link
Member Author

klion26 commented Oct 18, 2024

thanks for the review and merging! @zhoujinsong @majin1102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Improve the efficiency for RESTAPI of optimizing-processes
3 participants