-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Improve language key name and fix typo #3255
Conversation
These three variables are same? If they are, I will remove two variables. |
I found four place and I suggest keeping the last two, they have singular and plural forms.
|
And recommended to leave a space before and after the number.
|
I agree with @zhongqishang.
|
Thanks for your review. I will fix it tonight. |
@zhongqishang @zhoujinsong I had updated code. Please review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the work! @chouchouji |
Why are the changes needed?
Close #3251 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation