Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Improve language key name and fix typo #3255

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

chouchouji
Copy link
Contributor

Why are the changes needed?

Close #3251 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Oct 14, 2024
@chouchouji
Copy link
Contributor Author

@zhoujinsong

These three variables are same? If they are, I will remove two variables.

image

@zhongqishang
Copy link
Contributor

These three variables are same? If they are, I will remove two variables.

I found four place and I suggest keeping the last two, they have singular and plural forms.

  optimzerGroup: 'Optimizer Group',
  optimizergroup: 'Optimizer Groups',
  optimizerGroup: 'Optimizer Group', --keeping
  optimizerGroups: 'Optimizer Groups',, --keeping

@zhongqishang
Copy link
Contributor

And recommended to leave a space before and after the number.

  last1h: '最近 1小时',
  last12h: '最近 12小时',
  last24h: '最近 24小时',
  last7day: '最近 7天',

@zhoujinsong
Copy link
Contributor

These three variables are same? If they are, I will remove two variables.

I agree with @zhongqishang.
We should keep the following variables only:

optimizerGroup: 'Optimizer Group',
optimizerGroups: 'Optimizer Groups',

@chouchouji
Copy link
Contributor Author

These three variables are same? If they are, I will remove two variables.

I agree with @zhongqishang. We should keep the following variables only:

optimizerGroup: 'Optimizer Group',
optimizerGroups: 'Optimizer Groups',

Thanks for your review. I will fix it tonight.

@chouchouji
Copy link
Contributor Author

@zhongqishang @zhoujinsong I had updated code. Please review. Thanks!

Copy link
Contributor

@zhongqishang zhongqishang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 0a793da into apache:master Oct 18, 2024
1 check passed
@zhoujinsong
Copy link
Contributor

Thanks for the work! @chouchouji
Thanks for the review! @zhongqishang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Typos in en.ts and zh.ts
3 participants