Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3183] Add Ams On K8S TestContainer Unit Base Test (#3183) #3213

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wangyuxiang123
Copy link
Contributor

@wangyuxiang123 wangyuxiang123 commented Sep 20, 2024

Why are the changes needed?

Close #3183 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@wangyuxiang123 wangyuxiang123 changed the title [AMORO-3183] Add Ams On K8S TestContainer Unit Base Test [AMORO-3183] Add Ams On K8S TestContainer Unit Base Test (#3183) Sep 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.42%. Comparing base (8207efc) to head (829cf94).
Report is 27 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8207efc) and HEAD (829cf94). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8207efc) HEAD (829cf94)
core 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3213      +/-   ##
============================================
- Coverage     29.43%   22.42%   -7.01%     
+ Complexity     3685     2280    -1405     
============================================
  Files           568      379     -189     
  Lines         47267    38044    -9223     
  Branches       6196     5439     -757     
============================================
- Hits          13912     8532    -5380     
+ Misses        32372    28779    -3593     
+ Partials        983      733     -250     
Flag Coverage Δ
core ?
trino 22.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy006 czy006 self-requested a review September 20, 2024 09:38
<scope>test</scope>
</dependency>

<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just test use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add Ams On K8S TestContainer Unit Base Test
3 participants