Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointerException en MouseSystem #325

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix NullPointerException en MouseSystem #325

merged 1 commit into from
Apr 21, 2020

Conversation

cpbeto
Copy link
Contributor

@cpbeto cpbeto commented Apr 21, 2020

Chequea MapSystem.getTile(worldPos) por puntero null.
Agrega anotación @nullable y warning (@todo Revisar).

Hago referencia a #322.

@cpbeto
Fix NullPointerException en MouseSystem
7417c0a 
Chequea MapSystem.getTile(worldPos) por puntero null.
Agrega anotación @nullable y warning (@todo Revisar).
guidota
guidota approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@guidota guidota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podriamos convertirlo en optional, aunque creo que habria que tocar en muchos lugares jaj
Tile por Optional<Tile>

@cpbeto cpbeto merged commit deb9b33 into master Apr 21, 2020
@cpbeto cpbeto deleted the fix-mousesystem branch April 21, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidota guidota guidota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpbeto @guidota