generic verify_precompiles #3055
Open
+177
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
commented
Oct 2, 2024
| @@ -2260,7 +2261,7 @@ fn verify_transaction( | |||
| let move_precompile_verification_to_svm = | |||
| feature_set.is_active(&feature_set::move_precompile_verification_to_svm::id()); | |||
| if !move_precompile_verification_to_svm { | |||
| if let Err(e) = transaction.verify_precompiles(feature_set) { | |||
| if let Err(e) = verify_precompiles(transaction, feature_set) { | |||
There was a problem hiding this comment.
implementation change, no affect on the RPC interface.
apfitzge
commented
Oct 2, 2024
| @@ -107,6 +107,7 @@ assert_matches = { workspace = true } | |||
| ed25519-dalek = { workspace = true } | |||
| libsecp256k1 = { workspace = true } | |||
| memoffset = { workspace = true } | |||
| rand0-7 = { package = "rand", version = "0.7" } | |||
There was a problem hiding this comment.
need this to create the precompile instructions for testing.
logic was mainly copied from the individual precompile tests - if there's a better way without this old version would be happy to change & remove this
apfitzge
commented
Oct 2, 2024
| .get_or_insert_with(|| message.instructions_iter().map(|ix| ix.data).collect()); | ||
| precompile | ||
| .verify(instruction.data, all_instruction_data, feature_set) | ||
| .map_err(|_| TransactionError::InvalidAccountIndex)?; |
There was a problem hiding this comment.
kept error type here consistent with what tx.verify_precompiles returns...but this does not seem like the correct variant to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
verify_precompilesneeds to have a generic counterpart so that new transaction type(s) can verify themSummary of Changes
solana_runtime::verify_precompiles::verify_precompilesfnSanitizedTransaction::verify_precompileswas previously usedFixes #