DB Generation updates #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordTermor
added
bug
LordTermor
force-pushed
the
db-generation-fixes
branch
from
fc849cf
to
1c1f5ff
Compare
LordTermor
force-pushed
the
db-generation-fixes
branch
from
1c1f5ff
to
e1ab02b
Compare
LordTermor
force-pushed
the
db-generation-fixes
branch
from
e1ab02b
to
2fadbd0
Compare
romangg
approved these changes
Aug 24, 2024
dbcli/dbcli.cpp
Outdated
| @@ -62,8 +63,28 @@ int validate_and_rebuild(lmdb::txn& transaction, | |||
| continue; | |||
| } | |||
|
|
|||
| std::string signature = ""; | |||
There was a problem hiding this comment.
std::string is already empty initialized.
Makes use of PGPSIG desc-file field, saving b64 encoded package signature contents into it in addition to a detached .sig-file.
Checks PGPSIG field of downloaded database descriptions instead of always downloading a detached .sig-file. This saves times on additional downloads.
Added missing error strings for ParsingError.
Fixes a number of issues (anydistro#136, anydistro#120) by adding a size parameter for constructing string_view from vector of uint8s.
Adds dbcli validate/rebuild check for desc file correctness according to the package's pkginfo. Useful in case is desc-file in database is corrupted.
LordTermor
force-pushed
the
db-generation-fixes
branch
from
2fadbd0
to
57700d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a bunch of fixes/features/performance improvements related to database generation logic.
Closes #100, #120, #121, #136