-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry fixes #131
Entry fixes #131
Conversation
Is there an issue ticket for these fixes? |
No. It was an issue I've found and decided to fix right after that as it's pretty major |
|
from error it sounds like a body line limit
That sounds like a very weird limitation. What would be the point? Should body be multilined manually then?
Package entities used to contain only file path and version but with 8976f71 I've added full |
Traditionally there are good reasons to have some limit. I use 90 instead of 72 because displays are larger nowadays and max code line lengths in projects have typically also increased from 80 to something between 100 and 120.
Yes, there is a setting though for vim for example to do it automatically.
Thanks, that makes it clearer. For things like this having regression tests would be nice. |
Pool entries used to have only versions but now include whole .desc-files. Mapper should not be sufficed with version only anymore.
Signature path handling logic uses early return if signature was provided to `parse_file_path` which caused .desc file to never load in that case.
Loading .desc from package files every time RecordMapper::to_entity called is unnecessary and leads to massive performance issues. It's now being retrieved from the database.
This fixes some desc-file parsing logic so manually uploaded packages will get proper descriptions in database.