Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix global keyboard event is invalid in some case #2301

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix: fix global keyboard event is invalid in some case #2301

merged 1 commit into from
Jul 5, 2022

Conversation

MrMengJ
Copy link
Contributor

@MrMengJ MrMengJ commented Jul 2, 2022

Closes: #2300

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added pkg:x6 PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2601272104

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 2589785806: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #2301 (1757ed6) into master (d622db6) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2301   +/-   ##
=======================================
  Coverage   40.88%   40.88%           
=======================================
  Files         542      542           
  Lines       32296    32296           
  Branches     6572     6572           
=======================================
  Hits        13204    13204           
  Misses      18300    18300           
  Partials      792      792           
Flag Coverage Δ
x6 26.97% <0.00%> (ø)
x6-geometry 63.74% <ø> (ø)
x6-vector 94.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/graph/keyboard.ts 22.09% <0.00%> (ø)

@NewByVector NewByVector merged commit 0454995 into antvis:master Jul 5, 2022
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

全局快捷键失效
3 participants