Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hetzner Cloud Inventory source #14634

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

tomsiewert
Copy link
Contributor

@tomsiewert tomsiewert commented Nov 6, 2023

SUMMARY

This PR adds support for the dynamic inventory source "Hetzner Cloud" (hetzner.hcloud.hcloud).

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
  • UI
  • Collection
  • CLI
  • Docs
AWX VERSION
awx: 23.3.2.dev19+g4a46f258c0
ADDITIONAL INFORMATION

This PR requires ansible/awx-ee#219 to be merged

@AlanCoding
Copy link
Member

AWX allows custom credential types, allows SCM inventory sources, and allows customizing the default execution environment. Why do you want this in the built-in list of inventory sources as opposed to using these custom tools?

@tomsiewert
Copy link
Contributor Author

tomsiewert commented Nov 9, 2023

Thanks for your feedback @AlanCoding!

Why do you want this in the built-in list of inventory sources as opposed to using these custom tools?

A valid point and unfortunately, it was not directly obvious for me when I started to implement HC as Inventory Source. I looked in the docs before but obviously I couldn't find anything about "please use a custom credential type for custom inventory sources". I just looked into it more deeper and saw that it is "hidden" as a step in the "Sourced from a Project" section without any reference in the inventory sources part. Maybe this should be made more clear?

On the other side, I could also ask why we have vCenter or OpenStack as native inventory source? If I see this right, those inventory sources do nothing else than my current implementation (except for the compatibility layer).

@tomsiewert
Copy link
Contributor Author

Hey @AlanCoding @gundalow,

Is this still in review or do you say it's unnecessary to implement HC as inventory source and rather improve the documentation about how to use a custom inventory?

@djyasin djyasin requested a review from gundalow December 6, 2023 20:37
@dmzoneill dmzoneill marked this pull request as draft February 20, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants