-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hetzner Cloud Inventory source #14634
base: devel
Are you sure you want to change the base?
Conversation
4a46f25
to
2ccd1f7
Compare
AWX allows custom credential types, allows SCM inventory sources, and allows customizing the default execution environment. Why do you want this in the built-in list of inventory sources as opposed to using these custom tools? |
Thanks for your feedback @AlanCoding!
A valid point and unfortunately, it was not directly obvious for me when I started to implement HC as Inventory Source. I looked in the docs before but obviously I couldn't find anything about "please use a custom credential type for custom inventory sources". I just looked into it more deeper and saw that it is "hidden" as a step in the "Sourced from a Project" section without any reference in the inventory sources part. Maybe this should be made more clear? On the other side, I could also ask why we have vCenter or OpenStack as native inventory source? If I see this right, those inventory sources do nothing else than my current implementation (except for the compatibility layer). |
Hey @AlanCoding @gundalow, Is this still in review or do you say it's unnecessary to implement HC as inventory source and rather improve the documentation about how to use a custom inventory? |
Signed-off-by: Tom Siewert <[email protected]>
Signed-off-by: Tom Siewert <[email protected]>
Signed-off-by: Tom Siewert <[email protected]>
Signed-off-by: Tom Siewert <[email protected]>
2ccd1f7
to
b4fc91a
Compare
SUMMARY
This PR adds support for the dynamic inventory source "Hetzner Cloud" (
hetzner.hcloud.hcloud
).ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
This PR requires ansible/awx-ee#219 to be merged